Fixed the deleted-wrapper edge case. - #577
Merged
DragonSlayer62 merged 2 commits intoAug 8, 2026
Merged
Conversation
CJSEngine::AcquireObject() now refuses to create wrappers for deleted characters or items. This prevents a serial lookup from recreating a wrapper while the deleted native object is still waiting in the deletion queue.
…nup' into feature/libmozjs-115-13-2-cleanup
DragonSlayer62
merged commit Aug 8, 2026
92675ca
into
UOX3DevTeam:feature/libmozjs-115-13-2-cleanup
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CJSEngine::AcquireObject() now refuses to create wrappers for deleted characters or items.
This prevents a serial lookup from recreating a wrapper while the deleted native object is still waiting in the deletion queue.